Crucible and FishEye code review and repository browseris on line - Voip Sipx Development

Developer discussions for any of the sipX projects on sipfoundry.org 



Keywords  VoipDiscussionForumsCrucibleFishEyecodereviewrepositorybrowserislineSipxDevelopment

   Voip Discussion Forums -> Voip Sipx Development Report Spam.

 
AuthorMessage
Scott Lawrence
PostPosted: Wed Apr 22, 2009 8:11 pm    Post subject: Crucible and FishEye code review and repository browseris on lineReport Spam



We now have a couple more new tools available: Crucible and FishEye;
they are integrated and both at the same host:

http://code.sipfoundry.org/

Crucible is a code review tool - you can get basic instructions on how
to do a review at:
http://confluence.atlassian.com/display/CRUCIBLE/2.+Requesting+and+Conducting+a+Review

and there's an example of workflow that I think fits what we usually do
at:
http://confluence.atlassian.com/display/CRUCIBLE/4.+Defining+your+Workflow#4.DefiningyourWorkflow-OnetoManyReviewsWithoutaModerator(AgileTeam)

credentials to log in are the same as your tracker and subversion credentials.

Back to top
Damian Krzeminski
PostPosted: Wed Apr 22, 2009 8:51 pm    Post subject: Re: Crucible and FishEye code review and repositorybrowser is on lineReport Spam



Scott Lawrence wrote:
We now have a couple more new tools available: Crucible and FishEye;
they are integrated and both at the same host:

http://code.sipfoundry.org/

Crucible is a code review tool - you can get basic instructions on how
to do a review at:
http://confluence.atlassian.com/display/CRUCIBLE/2.+Requesting+and+Conducting+a+Review

and there's an example of workflow that I think fits what we usually do
at:
http://confluence.atlassian.com/display/CRUCIBLE/4.+Defining+your+Workflow#4.DefiningyourWorkflow-OnetoManyReviewsWithoutaModerator(AgileTeam)

credentials to log in are the same as your tracker and subversion credentials.


Do we want to try to use crucible as a basic way of sending patches.
Instead of attaching them in JIRA?

Does anyone know if there any way of creating review request from command
line? So that contributors can say something like:

git format-patches 4.0 | crucible-create-request --some --options


I have warn you all that it's a bit chatty at the moment. I added a test
patch and I got e-mail pretty much every time someone looked at it Smile
But I am sure there are some ways to adjust that. And if not there are
always e-mail filters Smile
D.
Back to top
Scott Lawrence
PostPosted: Wed Apr 22, 2009 9:18 pm    Post subject: Re: Crucible and FishEye code review and repositorybrowser is on lineReport Spam

On Wed, 2009-04-22 at 16:51 -0400, Damian Krzeminski wrote:
Do we want to try to use crucible as a basic way of sending patches.
Instead of attaching them in JIRA?

I like the idea.

If you create a Review and attach the patches to it, you can put a link
to that review in to the issue that you're changing to Patch Pending
state. There may well be Jira plugins that make this even easier
(anyone volunteering to research this?).

Does anyone know if there any way of creating review request from command
line? So that contributors can say something like:

git format-patches 4.0 | crucible-create-request --some --options

I believe there is some kind of remote api, so it may be possible to
build one.

I have warn you all that it's a bit chatty at the moment. I added a test
patch and I got e-mail pretty much every time someone looked at it Smile
But I am sure there are some ways to adjust that. And if not there are
always e-mail filters Smile

There are preferences you can change.
Back to top
Damian Krzeminski
PostPosted: Wed Apr 22, 2009 10:02 pm    Post subject: Re: Crucible and FishEye code review and repositorybrowser is on lineReport Spam

Scott Lawrence wrote:
On Wed, 2009-04-22 at 16:51 -0400, Damian Krzeminski wrote:
Do we want to try to use crucible as a basic way of sending patches.
Instead of attaching them in JIRA?

I like the idea.

If you create a Review and attach the patches to it, you can put a link
to that review in to the issue that you're changing to Patch Pending
state. There may well be Jira plugins that make this even easier
(anyone volunteering to research this?).

The thing I am concerned about is that there seem to be no easy way to get
patches from crucible.

I have 2 bash functions defined:

jira-apply() {
curl $1 | git apply -p0 --whitespace=strip
}

gjira-apply() {
curl $1 | git am -3 --whitespace=strip
}


Bit they only work if I can 'curl' something that looks like a patch or
better yet git patch. If someone spots something that I could use please
let me know.


Does anyone know if there any way of creating review request from command
line? So that contributors can say something like:

git format-patches 4.0 | crucible-create-request --some --options

I believe there is some kind of remote api, so it may be possible to
build one.

I have warn you all that it's a bit chatty at the moment. I added a test
patch and I got e-mail pretty much every time someone looked at it Smile
But I am sure there are some ways to adjust that. And if not there are
always e-mail filters Smile

There are preferences you can change.

Back to top
Scott Lawrence
PostPosted: Thu Apr 23, 2009 3:35 pm    Post subject: Re: Crucible/FishEye integration with Jira - upcomingmerger of sipX* Jira projectsReport Spam

Scott Lawrence wrote:

We now have a couple more new tools available: Crucible and FishEye;
they are integrated and both at the same host:

http://code.sipfoundry.org/

Damian Krzeminski asked:

Do we want to try to use crucible as a basic way of sending patches.
Instead of attaching them in JIRA?

There are a number of very cool looking features that do more powerful
integration of Crucible/FishEye with Jira, including opening new
Crucible reviews directly from the Jira issue. Those features have not
yet been enabled because they are harder to set up correctly with
multiple Jira projects.

This will be fixed shortly: we will be merging the sipXconfig and
sipXecs projects in the tracker so that we can start using the
integration (and incidentally, it will make it easier to get some
reports and filters that display the full status of the project).

The merger will renumber all the issues: they will all become 'XX-nnnn',
but Jira remembers the old numbers, so they will redirect to the correct
issue - old links will continue to work.

To help preserve the ability to look at different parts of the project
(and the teams that work on them), a new field has been added to all
issues: the Area field is a multi-checkbox field (so that issues can be
in more than one area, but this is expected to be rare) that has 4
values:

* Management
The management application and interfaces - essentially
the former sipXconfig project
* Operation
The rest of the code that runs in the product - all the
non-sipXconfig services - essentially the existing
sipXecs project.
* Documentation
The production of documentation.
* Testing
System test development and execution activities.

Existing issues will get this field set (hopefully mostly correctly) in
the process of moving (not until after the 'retirement' of old issues
announced earlier [1], because setting this field would Update the
issues and so nothing would be eligible for retirement).

The new sipXecs project has been created, but is closed (permissions set
so that nothing can be done with it yet). My plan is to move all issues
from the existing projects to the new merged one beginning some time
Friday afternoon or Saturday morning (EDT), and then close the existing
projects (which will then be empty anyway). The tracker will
essentially be unavailable during the move, but I expect it to only take
a couple of hours at most.

[1] http://list.sipfoundry.org/archive/sipx-dev/msg17522.html
and http://list.sipfoundry.org/archive/sipx-dev/msg17529.html
Back to top
Carolyn Beeton
PostPosted: Fri Apr 24, 2009 3:17 pm    Post subject: Re: Crucible and FishEye code review and repositorybrowser is on lineReport Spam

>
From: sipx-dev-bounces (AT) list (DOT) sipfoundry.org
[mailto:sipx-dev-bounces (AT) list (DOT) sipfoundry.org] On Behalf Of
Krzeminski, Damian (BL60:9D30)
Sent: Wednesday, April 22, 2009 6:03 PM
To: sipx-dev (AT) sipfoundry (DOT) org
Subject: Re: [sipX-dev] Crucible and FishEye code review and
repository browser is on line

Scott Lawrence wrote:
The thing I am concerned about is that there seem to be no
easy way to get patches from crucible.

I have 2 bash functions defined:

jira-apply() {
curl $1 | git apply -p0 --whitespace=strip }

gjira-apply() {
curl $1 | git am -3 --whitespace=strip }


Bit they only work if I can 'curl' something that looks like
a patch or better yet git patch. If someone spots something
that I could use please let me know.


try
http://code.sipfoundry.org/cru/XECS-5/downloadpatch/1/0001-XCF-3581-chan
ge-default-for-routing-emergency-calls.patch

or
http://code.sipfoundry.org/cru/XECS-3/downloadpatch/4/0002-XECS-2493-Add
-extra-DNS-records-for-SIP-Domain-if-it.patch

(in this case, I uploaded the patch twice, and it seems to have the same
name but it is now file number 4)

These links are available at the top of the review in the Patch[es]:
section.
Back to top
Scott Lawrence
PostPosted: Sat Apr 25, 2009 1:44 pm    Post subject: Merger of sipX* Jira projectsReport Spam

On Thu, 2009-04-23 at 11:35 -0400, Scott Lawrence wrote:

This will be fixed shortly: we will be merging the sipXconfig and
sipXecs projects in the tracker so that we can start using the
integration (and incidentally, it will make it easier to get some
reports and filters that display the full status of the project).

The merger will renumber all the issues: they will all become 'XX-nnnn',
but Jira remembers the old numbers, so they will redirect to the correct
issue - old links will continue to work.

I've completed the bulk of this merger of our tracker projects.

Unfortunately, this is not something that Jira has very good support for
- some fields cannot be automatically translated when moving issues,
even though the displayed values for those fields looks the same. There
was some unavoidable loss of information, particularly with Closed and
Resolved issues. The Affects Version information on many issues has
been lost.

I merged and slightly normalized the Component names.

A large part of this merger required my performing a long series of
manual operations to move issues, something I'm not especially good at
(I'd have happily spent twice as long to write a program to do this, but
couldn't figure out how). It is certain that I made some errors in this
process and have probably garbled some things in the process. I hope
there are not too many instances of this, and apologize profusely for
those that there are.
Back to top
Scott Lawrence
PostPosted: Sat Apr 25, 2009 1:47 pm    Post subject: Re: Merger of sipX* Jira projectsReport Spam

On Sat, 2009-04-25 at 09:44 -0400, Scott Lawrence wrote:

I've completed the bulk of this merger of our tracker projects.
One other thing... any filters you have will have to be recreated, since
the old sipXecs and sipXconfig projects they point to have been locked
and have no issues in them.
Back to top
Damian Krzeminski
PostPosted: Mon Apr 27, 2009 3:39 pm    Post subject: Re: Merger of sipX* Jira projectsReport Spam

Scott Lawrence wrote:
On Sat, 2009-04-25 at 09:44 -0400, Scott Lawrence wrote:

I've completed the bulk of this merger of our tracker projects.
One other thing... any filters you have will have to be recreated, since
the old sipXecs and sipXconfig projects they point to have been locked
and have no issues in them.


I was trying to recreate my filters (by using XX project and 'Management'
selected instead of old XCF project) but it looks like quite a few issues
somehow disappeared from management area. Most of the resolved issues do
not have any area field set.

Anyway - all my shared filters (starting with 'sipXconfig') are now
updated: if you used them in your Dashboard your JIRA pages should now
resemble what you had on Friday.

I also shared my sipXconfig dashboard: JIRA now will let you to use it as a
template when configuring your own dashboards.
D.
Back to top
Scott Lawrence
PostPosted: Tue Apr 28, 2009 8:45 pm    Post subject: Re: changing new Area field to TeamReport Spam

On Thu, 2009-04-23 I wrote:
To help preserve the ability to look at different parts of the project
(and the teams that work on them), a new field has been added to all
issues: the Area field is a multi-checkbox field (so that issues can be
in more than one area, but this is expected to be rare) that has 4
values:

* Management
The management application and interfaces - essentially
the former sipXconfig project
* Operation
The rest of the code that runs in the product - all the
non-sipXconfig services - essentially the existing
sipXecs project.
* Documentation
The production of documentation.
* Testing
System test development and execution activities.

It turns out that searching on a Multi-checkbox field is not as flexible
as we need - especially, you can't search for "none of these are
checked". So this field will shortly be replaced with a Multi-Select
field named 'Team' (because you can't change an existing custom field to
a new type) that has the additional value 'Undefined'.

For a short time during the transition, you may see both fields - until
tomorrow (Wed 4/29), just ignore the new Team multi-select field.
Back to top
   Voip Discussion Forums -> Voip Sipx DevelopmentAll times are GMT
Page 1 of 1

Related Topics